Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port hr_evaluation from 8.0 to 9.0/10.0 #343

Closed
dreispt opened this issue Jun 1, 2017 · 8 comments
Closed

Port hr_evaluation from 8.0 to 9.0/10.0 #343

dreispt opened this issue Jun 1, 2017 · 8 comments

Comments

@dreispt
Copy link
Sponsor Member

dreispt commented Jun 1, 2017

Also check OCA/survey#19 for an interesting extension.

@jcdrubay
Copy link

jcdrubay commented Jun 3, 2017

Here was that enterprise converted module: https://github.com/odoo/odoo/tree/8.0/addons/hr_evaluation

Also, should we work with standard backend views instead of the Survey module so it is easier to maintain? Also, it might be less in competition with Odoo SA; we would provide an alternative with a different design.

@dreispt
Copy link
Sponsor Member Author

dreispt commented Jun 3, 2017

In my experience the evaluations form varies a lot.
IMO surverys are a good solution for that.

@jcdrubay
Copy link

jcdrubay commented Jun 3, 2017

How about something like https://github.com/OCA/manufacture/tree/8.0/quality_control

We can define evaluation templates(Project Manager, Sales, ....). Then you can define a list of question for each template.

Each template can have a date of validity.

@elicoidal
Copy link

I am not in favor of reinventing the wheel either: survey is flexible and complete enough to fit the purpose.
Another model will become unmaintainable in the future

@jcdrubay
Copy link

jcdrubay commented Jun 4, 2017

I guess I am just scarred of survey because it already contains a lot of logic and a custom (website) view layer. Also, I have not yet had the chance to use it for a customer project so I could never dig deep into it nor feel the need to do so.
But if you master or want to master the survey module, I also agree that we should go with it.

@dreispt
Copy link
Sponsor Member Author

dreispt commented Jun 4, 2017

Module extracted from Odoo with #344
Migration PR should follow.

@dreispt
Copy link
Sponsor Member Author

dreispt commented Jun 4, 2017

Migration work is on #345
It should try to keep the same features.
Evolution and other changes should be left to later PRs.

@pedrobaeza
Copy link
Member

Closing this issue as there's a PR now.

sambarros pushed a commit to sambarros/hr that referenced this issue Jul 26, 2018
[BSSFL-469] Add missing final parameter in action create invoice
Mraimou pushed a commit to camptocamp/hr that referenced this issue Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants