Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.0][IMP] mis_builder: Show company of account detail in multicompany #242

Merged
merged 1 commit into from
Oct 17, 2019

Conversation

etobella
Copy link
Member

With this PR, we are able to see the company of the account on the label.
image

This PR does not change the behavior when multi_company is not selected.
image

@sbidoul
Copy link
Member

sbidoul commented Oct 14, 2019

Makes sense. +1

Could you do it as a PR to 10.0-staging? I'm preparing a release across versions real soon now and bring it to 11 from there.

Also it would be great if you could look if there is an easy spot to add a test for that.

@etobella
Copy link
Member Author

Sure!

@etobella etobella changed the base branch from 11.0 to 10.0-staging October 14, 2019 12:12
@sbidoul sbidoul changed the title [11.0][IMP] mis_builder: Show company of account detail in multicompany [10.0][IMP] mis_builder: Show company of account detail in multicompany Oct 14, 2019
@etobella
Copy link
Member Author

Tests added, it should be 🍏 now.

@jbeficent

Copy link
Sponsor Member

@JordiBForgeFlow JordiBForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants