-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deb external dependencies chicken and egg issue #33
Comments
Do you have a PR with the issue so I can see the context and the full logs? |
I've created a minimal example at https://github.com/GlodoUK/oca-ci-issue-33. The failure at https://github.com/GlodoUK/oca-ci-issue-33/runs/7308997757?check_suite_focus=true specifically is my area of interest :) Like I say, I'm happy to do the work, I'm just not sure if it's a manifestoo, or oca-ci issue, or a bit of both :) |
I see. The As you noticed, in this case we added the common dependencies in the ci image. So far for OCA it has not been too much of an issue in practice. I'm a bit reluctant to add this library to the oca-ci image because then where do we draw the line? Possible solutions that come to mind:
Not sure what's best... Out of curiosity, why pycurl instead of a pure python library ? |
Ah, that's my misunderstanding. It's obvious now you've pointed it out :)
Fully understand, and this wasn't something I was expecting at all :)
I'll see if we can prototype something and propose it over the next few days :) For now we've just added an extra step to our GitHub workflow.
We've had a scenario where we needed to talk to several different FTP servers directly from Odoo via a connector, and unfortunately every pure Python FTP library we tried had some form of problem. The main pain point was around TLS and session resumption. Anything that ultimately was based on ftplib we specifically hit https://bugs.python.org/issue10808 and https://bugs.python.org/issue19500. Workarounds to manage the issue were viable for 1 FTP server and then would break another. We needed a solution somewhat quickly and I reached for cURL because to date I've rarely had an issue. |
Is your feature request related to a problem?
Python libraries, such as PyCurl depend on apt/deb dependencies, unfortunately,
oca_install_addons
gets into a chicken and egg issue whereoca_list_external_dependencies
won't run until the Python deps are installed, but the Python deps cannot be installed until libcurl4-(openssl|nss|gnutls)-dev apt package is installed.i.e.
Describe the solution you'd like
Either:
Describe alternatives you've considered
N/A
Additional context
This seems to be a common issue where the workaround has been to modify the Dockerfile and add external dependencies, such as xmlsec1?
I am happy to do the leg work on this issue, but I'm not clear if it's an OCA-CI or a manifestoo issue, or both? Before I do any work I'd like some guidance or input in the better way to tackle this :)
The text was updated successfully, but these errors were encountered: