[8.0] web_ckeditor4 does not work in email templates/mako

[RoelAdriaans]

With the web_ckeditor4 enabled, editing an email template breaks the template.

The code before saving is, for example:

       % if object.origin:
       &nbsp;&nbsp;Order reference: ${object.origin}<br />
       % endif

and after saving:

% if object.origin: &nbsp;&nbsp;Order reference: ${object.origin}<br />
% endif %

The missing enters break the mako formatting engine, you have to edit the template by hand..
This is in 8.0.
(Ninja edit, %endif is not removed)

[pedrobaeza]

And % endif is also removed?

@antespi, you have also this issue, doesn't it?

[RoelAdriaans]

@pedrobaeza %end if is not removed, it's on a new line with the next % if next to it.
I've updated my paste..

0k/web_ckeditor#4 seems to be the same issue

[pedrobaeza]

I think that has to be treated on the ckeditor4 JS widget itself, not here, but @hbrunn should say about this

[hbrunn]

To fix this, we'll have to dive into ckeditor's internals, I think. http://docs.ckeditor.com/#!/api/CKEDITOR.htmlDataProcessor seems to be a good starting point. Or this looks even better: http://docs.ckeditor.com/#!/api/CKEDITOR.config-cfg-protectedSource

[antespi]

@pedrobaeza yes, we have the same issue.
@hbrunn yes, protectedSource regex maybe fix this.

[rafaelbn]

@hbrunn did you detect the same issue using https://github.com/OCA/crm/tree/8.0/newsletter when creating/editing emails templates Under Sales/Configuration/Newsletter type? (as newsletter installs ckeditor)

[hbrunn]

@RoelAdriaans-B-informed @pedrobaeza @antespi @rafaelbn

I think @lfreeke mentioned this problem once.

Should be fixed by #158

[RoelAdriaans]

#158 did not fix this issue

[rafaelbn]

As #158 didn't fix this issue, are any of you interested in fixing it? Are you using this module en production enviroments? We are still not using this module as corrupts many standards functionalities.

[rafaelbn]

Check #213 @hbrunn update ckeditor version

[rafaelbn]

@sergio-incaser @carlos-incaser as you are using web_ckeditor4 module I think you are interested in this issue. We are not using web_ckeditor4 by the moment. We need time to fix this issue and test it deeper to use with customers.

[psyray]

Hi,
This bug is still present, result after saving is the same as @RoelAdriaans-B-informed reports.

Is this planned to be resolved ?

[pedrobaeza]

If the PR already merged doesn't resolve it, I don't think so, as most of us have moved on to 9.0 or uninstall the module, but I can't speak for all.

[psyray]

Thanks for quick reply ;)
Is there a way to disable ck_editor for email templating ? Or must i use this module for all html content ?

[pedrobaeza]

Not now AFAIK, as this one replaces default HTML editor.

[psyray]

Ok thanks, I will disable this module.

[github-actions]

There hasn't been any activity on this issue in the past 6 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this issue to never become stale, please ask a PSC member to apply the "no stale" label.