fix(game-creator): catch exc when removing path (#1474)

* fix(game-creator): catch exc when removing path * test with no ingress
ocadotechnology · Feb 26, 2021 · 40e7e1e · 40e7e1e
1 parent b66830e
commit 40e7e1e
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/aimmo-game-creator/game_manager.py b/aimmo-game-creator/game_manager.py
@@ -205,7 +205,11 @@ def _remove_path_from_ingress(self, game_id):
         path = kubernetes.client.NetworkingV1beta1HTTPIngressPath(
             backend, f"/{game_name}(/|$)(.*)"
         )
-        ingress = self.networking_api.list_namespaced_ingress("default").items[0]
+        try:
+            ingress = self.networking_api.list_namespaced_ingress("default").items[0]
+        except IndexError:
+            LOGGER.warning("No ingress found to remove path from.")
+            return
         paths = ingress.spec.rules[0].http.paths
         try:
             index_to_delete = paths.index(path)

diff --git a/aimmo-game-creator/tests/test_game_manager.py b/aimmo-game-creator/tests/test_game_manager.py
@@ -166,3 +166,7 @@ def test_delete_game(self):
                 ),
             ]
         )
+
+        # Test again with no ingress
+        game_manager.networking_api.list_namespaced_ingress.return_value.items = []
+        game_manager.delete_game(100)