Skip to content

Commit

Permalink
fix: [Snyk] Security upgrade parcel-bundler from 1.12.4 to 1.12.5 (#1483
Browse files Browse the repository at this point in the history
)

* fix: game_frontend/package.json & game_frontend/yarn.lock to reduce vulnerabilities

The following vulnerabilities are fixed with an upgrade:
- https://snyk.io/vuln/SNYK-JS-NODEFORGE-598677

* Merge branch 'development' into snyk-fix-0635a726362685bc91fd9eecb9534f53

* Merge branch 'development' into snyk-fix-0635a726362685bc91fd9eecb9534f53

* recreated yarn.lock and test snapshots

* Merge branch 'development' into snyk-fix-0635a726362685bc91fd9eecb9534f53
  • Loading branch information
snyk-bot committed Mar 24, 2021
1 parent a4ea007 commit afbf227
Show file tree
Hide file tree
Showing 5 changed files with 2,881 additions and 2,741 deletions.
3 changes: 1 addition & 2 deletions game_frontend/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
"@babel/preset-react": "^7.6.3",
"@babel/preset-typescript": "^7.6.0",
"@babel/runtime": "^7.6.3",
"@types/cypress": "^1.1.3",
"@types/enzyme": "^3.10.3",
"@types/jest": "^24.0.15",
"@typescript-eslint/eslint-plugin": "^2.23.0",
Expand Down Expand Up @@ -63,7 +62,7 @@
"immer": "^8.0.1",
"js-cookie": "^2.2.1",
"lodash.isequal": "^4.5.0",
"parcel-bundler": "^1.12.4",
"parcel-bundler": "^1.12.5",
"react": "^16.8.6",
"react-ace": "^9.0.0",
"react-dom": "^16.8.6",
Expand Down
7 changes: 4 additions & 3 deletions game_frontend/src/babylon/entities/obstacleManager.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import ObstacleManager from './obstacleManager'
import dummyImportMeshAsync from '../../testHelpers/dummyImportMeshAsync'
import AssetPack from '../assetPacks/assetPack'
import { DiffItem } from '../diff'
import { Vector3 } from 'babylonjs'

let environment: MockEnvironment
let obstacles: ObstacleManager
Expand Down Expand Up @@ -39,7 +40,7 @@ describe('obstacle', () => {
const meshes = obstacles.obstacleNode.getChildMeshes()

expect(meshes.length).toBe(1)
expect(meshes[0].position).toEqual({ x: 0, y: 0, z: 0 })
expect(meshes[0].position).toEqual(new Vector3(0, 0, 0))
})

it('deletes an obstacle', async () => {
Expand All @@ -64,7 +65,7 @@ describe('obstacle', () => {
let meshes = obstacles.obstacleNode.getChildMeshes()

expect(meshes.length).toBe(1)
expect(meshes[0].position).toEqual({ x: 0, y: 0, z: 0 })
expect(meshes[0].position).toEqual(new Vector3(0, 0, 0))

const updatedObstacle = obstacleDiffItem(1, { x: 1, y: 1 })

Expand All @@ -73,6 +74,6 @@ describe('obstacle', () => {
meshes = obstacles.obstacleNode.getChildMeshes()

expect(meshes.length).toBe(1)
expect(meshes[0].position).toEqual({ x: 1, y: 0, z: 1 })
expect(meshes[0].position).toEqual(new Vector3(1, 0, 1))
})
})
Loading

0 comments on commit afbf227

Please sign in to comment.