Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

fix: Re-add env setting #1627

Merged
merged 3 commits into from
Feb 22, 2022
Merged

fix: Re-add env setting #1627

merged 3 commits into from
Feb 22, 2022

Conversation

faucomte97
Copy link
Contributor

@faucomte97 faucomte97 commented Feb 22, 2022

This change is Reviewable

@faucomte97 faucomte97 self-assigned this Feb 22, 2022
@faucomte97 faucomte97 enabled auto-merge (squash) February 22, 2022 18:15
Copy link
Collaborator

@razvan-pro razvan-pro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @faucomte97)

Copy link
Collaborator

@razvan-pro razvan-pro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, 2 of 2 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @faucomte97)

@codecov
Copy link

codecov bot commented Feb 22, 2022

Codecov Report

Merging #1627 (f3d4a3e) into master (29ae2e7) will increase coverage by 19.50%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1627       +/-   ##
===========================================
+ Coverage   68.06%   87.57%   +19.50%     
===========================================
  Files         165       36      -129     
  Lines        3338     1014     -2324     
  Branches      278      153      -125     
===========================================
- Hits         2272      888     -1384     
+ Misses       1038      102      -936     
+ Partials       28       24        -4     
Impacted Files Coverage Δ
aimmo-game/simulation/game_runner.py 69.84% <100.00%> (-0.93%) ⬇️
aimmo-game/setup.py
aimmo/views.py
aimmo/worksheets.py
...ame_frontend/src/redux/features/Analytics/index.js
game_frontend/src/redux/features/Game/types.js
...ame_frontend/src/components/RunCodeButton/index.js
game_frontend/src/components/icons/Clear.js
aimmo/permissions.py
aimmo-game/simulation/event.py
... and 120 more

@faucomte97 faucomte97 merged commit f342bac into master Feb 22, 2022
@faucomte97 faucomte97 deleted the fix_frontend_bundling branch March 1, 2022 16:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants