Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: migrations created_by #1712

Merged
merged 3 commits into from
Oct 10, 2022
Merged

fix: migrations created_by #1712

merged 3 commits into from
Oct 10, 2022

Conversation

KamilPawel
Copy link
Collaborator

@KamilPawel KamilPawel commented Oct 10, 2022

Description

How Has This Been Tested?

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have linked this PR to a ZenHub Issue.

This change is Reviewable

@KamilPawel KamilPawel self-assigned this Oct 10, 2022
Copy link
Member

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @KamilPawel)

Copy link
Member

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @KamilPawel)


aimmo/migrations/0030_update_created_by.py line 7 at r2 (raw file):

def populate_created_by(apps, schema_editor):
    Game = apps.get_model("aimmo", "Game")
    Teacher = apps.get_model("common", "Teacher")

Do you need this??

Copy link
Member

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @KamilPawel)

@codecov
Copy link

codecov bot commented Oct 10, 2022

Codecov Report

Merging #1712 (6fa8b7e) into master (37c26ba) will increase coverage by 21.63%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1712       +/-   ##
===========================================
+ Coverage   66.32%   87.95%   +21.63%     
===========================================
  Files         179       38      -141     
  Lines        3661     1046     -2615     
  Branches      255      109      -146     
===========================================
- Hits         2428      920     -1508     
+ Misses       1201      103     -1098     
+ Partials       32       23        -9     
Impacted Files Coverage Δ
aimmo/migrations/0030_update_created_by.py
aimmo/migrations/0015_game_worksheet.py
..._frontend/src/redux/features/AvatarWorker/epics.js
aimmo/migrations/0004_auto_20160808_1511.py
aimmo/avatar_examples/health_seeker_avatar.py
aimmo/setup.py
game_frontend/src/components/Code/index.js
example_project/settings.py
...ame_frontend/src/babylon/entities/avatarManager.ts
aimmo/migrations/0013_alter_game_can_play.py
... and 133 more

@KamilPawel KamilPawel enabled auto-merge (squash) October 10, 2022 13:29
@KamilPawel KamilPawel merged commit d45ba57 into master Oct 10, 2022
@faucomte97 faucomte97 deleted the fix_migrations branch August 9, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants