-
Notifications
You must be signed in to change notification settings - Fork 71
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @KamilPawel)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @KamilPawel)
aimmo/migrations/0030_update_created_by.py
line 7 at r2 (raw file):
def populate_created_by(apps, schema_editor): Game = apps.get_model("aimmo", "Game") Teacher = apps.get_model("common", "Teacher")
Do you need this??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @KamilPawel)
Codecov Report
@@ Coverage Diff @@
## master #1712 +/- ##
===========================================
+ Coverage 66.32% 87.95% +21.63%
===========================================
Files 179 38 -141
Lines 3661 1046 -2615
Branches 255 109 -146
===========================================
- Hits 2428 920 -1508
+ Misses 1201 103 -1098
+ Partials 32 23 -9 |
Description
How Has This Been Tested?
Checklist:
This change is