-
Notifications
You must be signed in to change notification settings - Fork 72
fix: adding pause #1744
fix: adding pause #1744
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 6 files at r3, 8 of 26 files at r5, 2 of 13 files at r6, 29 of 31 files at r7, 2 of 2 files at r8, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @KamilPawel)
game_frontend/src/containers/IDEEditor/index.js
line 148 at r8 (raw file):
variant="outlined" onClick={this.onPauseClicked} startIcon={<PauseCircleFilled />}
This icon needs to change when the game is paused, ideally to a play arrow, like a "resume" arrow like on YouTube for example.
game_frontend/src/redux/features/Game/epics.js
line 87 at r8 (raw file):
action$.pipe( ofType(types.TOGGLE_PAUSE_GAME), filter(() => state$.value.game.gamePaused === true),
do we need === true
?
game_frontend/src/redux/features/Game/epics.js
line 89 at r8 (raw file):
filter(() => state$.value.game.gamePaused === true), map(() => avatarWorkerActions.avatarsNextActionComputed({ turnCount: state$.value.game.gameState.turnCount + 1, log: "You have paused the game" })
I know it wasn't in the task description but can we have a log similar to this one when the player resumes the game? Something like "You have resumed the game"
game_frontend/src/redux/features/Game/epics.js
line 96 at r8 (raw file):
action$.pipe( ofType(types.TOGGLE_PAUSE_GAME), filter(() => state$.value.game.gamePaused === true),
Same question here about the === true
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r9, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @KamilPawel)
Codecov Report
@@ Coverage Diff @@
## master #1744 +/- ##
===========================================
+ Coverage 66.32% 87.95% +21.63%
===========================================
Files 179 38 -141
Lines 3661 1046 -2615
Branches 255 109 -146
===========================================
- Hits 2428 920 -1508
+ Misses 1201 103 -1098
+ Partials 32 23 -9
|
Description
How Has This Been Tested?
Checklist:
This change is