Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

fix: Kurono badges trigger #1777

Merged
merged 2 commits into from
Jun 16, 2023
Merged

fix: Kurono badges trigger #1777

merged 2 commits into from
Jun 16, 2023

Conversation

cewei8483
Copy link
Contributor

@cewei8483 cewei8483 commented Jun 9, 2023

Description

How Has This Been Tested?

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have linked this PR to a ZenHub Issue.

This change is Reviewable

@cewei8483 cewei8483 linked an issue Jun 9, 2023 that may be closed by this pull request
@cewei8483 cewei8483 changed the title fix: compare badges with the same worksheet fix: Kurono badges trigger Jun 9, 2023
Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @cewei8483)

@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Merging #1777 (4a14aac) into master (49a8345) will increase coverage by 0.70%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1777      +/-   ##
==========================================
+ Coverage   66.72%   67.43%   +0.70%     
==========================================
  Files         183      183              
  Lines        3736     3737       +1     
  Branches      264      264              
==========================================
+ Hits         2493     2520      +27     
+ Misses       1212     1189      -23     
+ Partials       31       28       -3     
Impacted Files Coverage Δ
...ame_frontend/src/components/NavigationBar/index.js 94.59% <100.00%> (+66.81%) ⬆️

... and 1 file with indirect coverage changes

@cewei8483 cewei8483 merged commit 3c3f4be into master Jun 16, 2023
8 checks passed
@cewei8483 cewei8483 deleted the 1776-kurono-badges-trigger branch June 16, 2023 10:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kurono badges trigger
2 participants