fix: track worksheet usage #1828
Conversation
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @SKairinos)
aimmo/views.py line 223 at r1 (raw file):
game.save() WorksheetUsage.objects.create(
This would create a WorksheetUsage object every time someone watches the game = every time any user clicks Play or enters the URL for the game, teachers & students alike. Just double-checking that is what we want (I thought we mainly wanted to just keep track of when a Game changes Worksheet).
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @faucomte97)
aimmo/views.py line 223 at r1 (raw file):
Previously, faucomte97 (Florian Aucomte) wrote…
This would create a WorksheetUsage object every time someone watches the game = every time any user clicks Play or enters the URL for the game, teachers & students alike. Just double-checking that is what we want (I thought we mainly wanted to just keep track of when a Game changes Worksheet).
I'm aware - it was intentional. I want to capture every time someone uses/plays a game/worksheet. This way, we know which are most used worksheets
There was a problem hiding this comment.
Reviewable status:
complete! all files reviewed, all discussions resolved (waiting on @SKairinos)
There was a problem hiding this comment.
Reviewable status:
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1828 +/- ##
==========================================
+ Coverage 66.32% 70.60% +4.28%
==========================================
Files 179 190 +11
Lines 3661 3950 +289
Branches 255 272 +17
==========================================
+ Hits 2428 2789 +361
+ Misses 1201 1132 -69
+ Partials 32 29 -3
|
This change is