-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: track worksheet usage #1828
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @SKairinos)
aimmo/views.py
line 223 at r1 (raw file):
game.save() WorksheetUsage.objects.create(
This would create a WorksheetUsage object every time someone watches the game = every time any user clicks Play or enters the URL for the game, teachers & students alike. Just double-checking that is what we want (I thought we mainly wanted to just keep track of when a Game changes Worksheet).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @faucomte97)
aimmo/views.py
line 223 at r1 (raw file):
Previously, faucomte97 (Florian Aucomte) wrote…
This would create a WorksheetUsage object every time someone watches the game = every time any user clicks Play or enters the URL for the game, teachers & students alike. Just double-checking that is what we want (I thought we mainly wanted to just keep track of when a Game changes Worksheet).
I'm aware - it was intentional. I want to capture every time someone uses/plays a game/worksheet. This way, we know which are most used worksheets
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status:
complete! all files reviewed, all discussions resolved (waiting on @SKairinos)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status:
complete! all files reviewed, all discussions resolved (waiting on @SKairinos)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @SKairinos)
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1828 +/- ##
==========================================
+ Coverage 66.32% 70.60% +4.28%
==========================================
Files 179 190 +11
Lines 3661 3950 +289
Branches 255 272 +17
==========================================
+ Hits 2428 2789 +361
+ Misses 1201 1132 -69
+ Partials 32 29 -3
|
This change is![Reviewable](https://camo.githubusercontent.com/23b05f5fb48215c989e92cc44cf6512512d083132bd3daf689867c8d9d386888/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)