Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Upgrade dependencies #1420

Merged
merged 7 commits into from
Nov 30, 2020
Merged

fix: Upgrade dependencies #1420

merged 7 commits into from
Nov 30, 2020

Conversation

faucomte97
Copy link
Member

@faucomte97 faucomte97 commented Nov 27, 2020 •
edited by OlafSzmidt
Loading

This change is Reviewable

@faucomte97 faucomte97 self-assigned this Nov 27, 2020
@codecov
Copy link

codecov bot commented Nov 27, 2020 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (django_2_upgrade@2489966). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@                 Coverage Diff                 @@
##             django_2_upgrade    #1420   +/-   ##
===================================================
  Coverage                    ?   74.79%           
===================================================
  Files                       ?       68           
  Lines                       ?      988           
  Branches                    ?      124           
===================================================
  Hits                        ?      739           
  Misses                      ?      246           
  Partials                    ?        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2489966...8217c44. Read the comment docs.

razvan-pro
razvan-pro approved these changes Nov 27, 2020
View reviewed changes
Copy link
Collaborator

@razvan-pro razvan-pro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @faucomte97)

razvan-pro
razvan-pro approved these changes Nov 27, 2020
View reviewed changes
Copy link
Collaborator

@razvan-pro razvan-pro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @faucomte97)

razvan-pro
razvan-pro approved these changes Nov 30, 2020
View reviewed changes
Copy link
Collaborator

@razvan-pro razvan-pro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r3.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @faucomte97)

@faucomte97 faucomte97 merged commit e62d6c8 into django_2_upgrade Nov 30, 2020
@faucomte97 faucomte97 deleted the upgrade_dependencies branch November 30, 2020 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@razvan-pro razvan-pro razvan-pro approved these changes

Assignees

@faucomte97 faucomte97

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@faucomte97 @razvan-pro