Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Rename worksheet label to Challenge #1427

Merged
merged 9 commits into from
Dec 10, 2020
Merged

Conversation

faucomte97
Copy link
Member

@faucomte97 faucomte97 commented Dec 8, 2020

Selection_198


This change is Reviewable

@faucomte97 faucomte97 self-assigned this Dec 8, 2020
@codecov
Copy link

codecov bot commented Dec 8, 2020

Codecov Report

Merging #1427 (63adab7) into development (c07c6f2) will decrease coverage by 18.18%.
The diff coverage is 80.00%.

Impacted file tree graph

@@               Coverage Diff                @@
##           development    #1427       +/-   ##
================================================
- Coverage        74.79%   56.60%   -18.19%     
================================================
  Files               68      168      +100     
  Lines              988     3911     +2923     
  Branches           124      225      +101     
================================================
+ Hits               739     2214     +1475     
- Misses             246     1676     +1430     
- Partials             3       21       +18     
Impacted Files Coverage Δ
aimmo_runner/runner.py 0.00% <0.00%> (ø)
aimmo/forms.py 93.10% <87.50%> (ø)
aimmo/__init__.py 100.00% <100.00%> (ø)
aimmo-game/simulation/interactables/conditions.py 66.66% <0.00%> (ø)
...immo/migrations/0021_add_pdf_names_to_worksheet.py 100.00% <0.00%> (ø)
aimmo/migrations/0011_reset_game_tokens.py 100.00% <0.00%> (ø)
aimmo/migrations/0003_auto_20160802_1418.py 48.27% <0.00%> (ø)
aimmo-game/simulation/world_map.py 0.00% <0.00%> (ø)
aimmo/models.py 94.18% <0.00%> (ø)
aimmo/migrations/0017_add_worksheet_1_and_2.py 100.00% <0.00%> (ø)
... and 93 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 575d743...63adab7. Read the comment docs.

Copy link
Collaborator

@razvan-pro razvan-pro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r3.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Collaborator

@razvan-pro razvan-pro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r6.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @faucomte97)


aimmo/forms.py, line 60 at r6 (raw file):

            raise ValidationError("Sorry, an invalid class was entered")

        if worksheet and not Worksheet.objects.fitler(pk=worksheet.id).exists():

fitler? 🙂

Copy link
Collaborator

@razvan-pro razvan-pro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r7.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @faucomte97)

@faucomte97 faucomte97 merged commit 9529bf0 into development Dec 10, 2020
@faucomte97 faucomte97 deleted the rename_form_label branch December 10, 2020 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants