-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Rename worksheet label to Challenge #1427
Conversation
Codecov Report
@@ Coverage Diff @@
## development #1427 +/- ##
================================================
- Coverage 74.79% 56.60% -18.19%
================================================
Files 68 168 +100
Lines 988 3911 +2923
Branches 124 225 +101
================================================
+ Hits 739 2214 +1475
- Misses 246 1676 +1430
- Partials 3 21 +18
Continue to review full report at Codecov.
|
…y/aimmo into rename_form_label
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3.
Reviewable status:complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r6.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @faucomte97)
aimmo/forms.py, line 60 at r6 (raw file):
raise ValidationError("Sorry, an invalid class was entered") if worksheet and not Worksheet.objects.fitler(pk=worksheet.id).exists():
fitler? 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r7.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @faucomte97)
This change is![Reviewable](https://camo.githubusercontent.com/23b05f5fb48215c989e92cc44cf6512512d083132bd3daf689867c8d9d386888/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)