feat: update console theme to modified monokai, then increase font size to 18px #1468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…18px (default was 1rem)
dionizh
changed the title
faucomte97
approved these changes
Feb 22, 2021
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @dionizh)
Codecov Report
@@ Coverage Diff @@
## development #1468 +/- ##
============================================
Coverage 62.77% 62.77%
============================================
Files 167 167
Lines 3627 3627
Branches 222 222
============================================
Hits 2277 2277
Misses 1326 1326
Partials 24 24
|
faucomte97
approved these changes
Feb 22, 2021
There was a problem hiding this comment.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wasn't sure whether this is the best way to do it, felt a bit hacky. But there seems to be no way to create a custom theme for AceEditor (couldn't find it anywhere in their docs or google). As far as I can see handlebars_template.html is used only for the console so it can be modified however we like? Let me know if I missed anything.
This change is