Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove teacher title #1566

Merged
merged 1 commit into from
Aug 19, 2021
Merged

Conversation

razvan-pro
Copy link
Collaborator

@razvan-pro razvan-pro commented Aug 18, 2021

This will fix the tests after deploying the portal change.


This change is Reviewable

@razvan-pro razvan-pro changed the base branch from development to master August 18, 2021 17:05
@razvan-pro razvan-pro changed the base branch from master to rebranding-p1 August 18, 2021 17:05
@razvan-pro razvan-pro self-assigned this Aug 18, 2021
Copy link
Contributor

@dionizh dionizh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @razvan-pro)

@codecov
Copy link

codecov bot commented Aug 19, 2021

Codecov Report

Merging #1566 (733fa25) into rebranding-p1 (89b4162) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##           rebranding-p1    #1566   +/-   ##
==============================================
  Coverage          67.56%   67.56%           
==============================================
  Files                161      161           
  Lines               3317     3317           
  Branches             234      234           
==============================================
  Hits                2241     2241           
  Misses              1048     1048           
  Partials              28       28           

@razvan-pro razvan-pro merged commit 1fae7be into rebranding-p1 Aug 19, 2021
@razvan-pro razvan-pro deleted the rebranding-remove-teacher-title branch August 19, 2021 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants