feat: Implement CSP header #1586
Conversation
There was a problem hiding this comment.
Reviewed 4 of 6 files at r1, 4 of 4 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @faucomte97)
aimmo/autoconfig.py, line 48 at r2 (raw file):
"ws://localhost:41949/", "ws://192.168.58.2:7959/socket.io/", "http://192.168.58.2:7959/socket.io/",
Minor, hmm, I have a feeling this may not be the same on all machines - we'll probably disable CSP on localhost though.
There was a problem hiding this comment.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @faucomte97)
aimmo/autoconfig.py, line 30 at r2 (raw file):
], "USE_TZ": True, # ----------------------------------------------------------------------------------
Same comment about separation 😁
# Conflicts: # Pipfile.lock
There was a problem hiding this comment.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @faucomte97 and @razvan-pro)
aimmo/autoconfig.py, line 30 at r2 (raw file):
Previously, razvan-pro (Razvan Mahu) wrote…
Same comment about separation 😁
Done.
There was a problem hiding this comment.
Reviewable status: 5 of 9 files reviewed, 2 unresolved discussions (waiting on @faucomte97 and @razvan-pro)
aimmo/autoconfig.py, line 48 at r2 (raw file):
Previously, razvan-pro (Razvan Mahu) wrote…
Minor, hmm, I have a feeling this may not be the same on all machines - we'll probably disable CSP on localhost though.
Should I leave it for now?
Should we test it on other machines?
There was a problem hiding this comment.
Reviewable status: 5 of 9 files reviewed, 1 unresolved discussion (waiting on @faucomte97 and @razvan-pro)
aimmo/autoconfig.py, line 48 at r2 (raw file):
Previously, faucomte97 (Florian Aucomte) wrote…
Should I leave it for now?
Should we test it on other machines?
Done.
There was a problem hiding this comment.
Reviewed 3 of 4 files at r3, 1 of 1 files at r6, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @faucomte97)
Codecov Report
@@ Coverage Diff @@
## development #1586 +/- ##
===============================================
+ Coverage 67.74% 67.87% +0.13%
===============================================
Files 165 163 -2
Lines 3339 3325 -14
Branches 235 235
===============================================
- Hits 2262 2257 -5
+ Misses 1049 1040 -9
Partials 28 28
|
This change is