fix: scale cars #1661
fix: scale cars #1661
Conversation
There was a problem hiding this comment.
Reviewed 8 of 9 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @KamilPawel)
aimmo/worksheets.py line 199 at r2 (raw file):
# - avatar_state.backpack -> LIST OF HELD ARTEFACTS # - artefact.type -> TYPE (e.g. artefact_types.KEY or artefact_types.CHEST) #
We can remove this empty line to keep it consistent with other started codes
game_frontend/src/babylon/assetPacks/modern.ts line 83 at r2 (raw file):
*/ createRandomRotation(obstacle: any): number {
Arg can be removed
game_frontend/src/babylon/assetPacks/modern.ts line 94 at r2 (raw file):
return Math.floor(Math.random() * max) } return angles[getRandomInt(4)]
I think this could be Math.PI * Math.floor(Math.random() * 4) / 2 to avoid the dict
There was a problem hiding this comment.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @razvan-pro)
aimmo/worksheets.py line 199 at r2 (raw file):
Previously, razvan-pro (Razvan Mahu) wrote…
We can remove this empty line to keep it consistent with other started codes
Done.
game_frontend/src/babylon/assetPacks/modern.ts line 83 at r2 (raw file):
Previously, razvan-pro (Razvan Mahu) wrote…
Arg can be removed
Done.
game_frontend/src/babylon/assetPacks/modern.ts line 94 at r2 (raw file):
Previously, razvan-pro (Razvan Mahu) wrote…
I think this could be
Math.PI * Math.floor(Math.random() * 4) / 2to avoid the dict
Done.
There was a problem hiding this comment.
Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @KamilPawel)
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @KamilPawel)
aimmo/worksheets.py line 198 at r3 (raw file):
# - MoveTowardsAction(ARTEFACT) # - avatar_state.backpack -> LIST OF HELD ARTEFACTS # - artefact.type -> TYPE (e.g. artefact_types.KEY or artefact_types.CHEST)
Remove the bit in the brackets please.
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dionizh)
aimmo/worksheets.py line 198 at r3 (raw file):
Previously, dionizh (Dioni Zhong) wrote…
Remove the bit in the brackets please.
Done.
There was a problem hiding this comment.
Reviewed 1 of 1 files at r5, all commit messages.
Reviewable status:
Codecov Report
@@ Coverage Diff @@
## worksheet4 #1661 +/- ##
==============================================
- Coverage 68.00% 67.98% -0.03%
==============================================
Files 165 165
Lines 3376 3377 +1
Branches 283 283
==============================================
Hits 2296 2296
- Misses 1053 1054 +1
Partials 27 27
|
This change is