Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Upgrade Python to 3.8 #1778

Merged
merged 3 commits into from
Jun 23, 2023
Merged

feat: Upgrade Python to 3.8 #1778

merged 3 commits into from
Jun 23, 2023

Conversation

cewei8483
Copy link
Collaborator

@cewei8483 cewei8483 commented Jun 22, 2023

Description

How Has This Been Tested?

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have linked this PR to a ZenHub Issue.

This change is Reviewable

@cewei8483 cewei8483 linked an issue Jun 22, 2023 that may be closed by this pull request
Copy link
Member

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 8 of 8 files at r1, 7 of 7 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @cewei8483)

@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

Merging #1778 (3f0bf65) into master (d92982e) will increase coverage by 0.70%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1778      +/-   ##
==========================================
+ Coverage   66.73%   67.44%   +0.70%     
==========================================
  Files         178      183       +5     
  Lines        3638     3772     +134     
  Branches      250      264      +14     
==========================================
+ Hits         2428     2544     +116     
- Misses       1184     1200      +16     
- Partials       26       28       +2     

see 23 files with indirect coverage changes

@cewei8483 cewei8483 merged commit ebf6131 into master Jun 23, 2023
9 checks passed
@faucomte97 faucomte97 deleted the 10-python-upgrade branch August 9, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python upgrade
2 participants