Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Stop games on deletion #1791

Merged
merged 2 commits into from
Jul 24, 2023
Merged

fix: Stop games on deletion #1791

merged 2 commits into from
Jul 24, 2023

Conversation

faucomte97
Copy link
Member

@faucomte97 faucomte97 commented Jul 20, 2023

  • Mark games as stopped when deleting them
  • There was no need to stop them on worksheet change actually as it does not delete and recreate a game as far as the DB is concerned.
  • Added a few fields in the Django admin so we can check game creation time as well as archived state.

This change is Reviewable

@faucomte97 faucomte97 self-assigned this Jul 20, 2023
Copy link
Contributor

@SKairinos SKairinos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @faucomte97)

@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Merging #1791 (f2f316e) into master (551c009) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1791   +/-   ##
=======================================
  Coverage   67.44%   67.45%           
=======================================
  Files         183      183           
  Lines        3772     3773    +1     
  Branches      264      264           
=======================================
+ Hits         2544     2545    +1     
  Misses       1200     1200           
  Partials       28       28           
Impacted Files Coverage Δ
aimmo/admin.py 64.70% <100.00%> (ø)
aimmo/views.py 93.46% <100.00%> (+0.04%) ⬆️

@faucomte97 faucomte97 merged commit 6066321 into master Jul 24, 2023
9 checks passed
@faucomte97 faucomte97 deleted the stop_games_handlers branch July 24, 2023 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants