-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Vagrant option from runner #644
Conversation
Reviewed 5 of 5 files at r1. ubuntu_setup.sh, line 1 at r1 (raw file):
could be add something in our docs to refer people to this script? Comments from Reviewable |
Review status: 4 of 5 files reviewed, 1 unresolved discussion (waiting on @mrniket and @riaJha97) ubuntu_setup.sh, line 1 at r1 (raw file): Previously, mrniket (Niket Shah) wrote…
Not too sure where it should go. Shall I just link to this script in the README or should it be another section in usage.md? Comments from Reviewable |
Review status: 4 of 5 files reviewed, 1 unresolved discussion (waiting on @mrniket) ubuntu_setup.sh, line 1 at r1 (raw file): Previously, riaJha97 wrote…
I would link to the script in the readme, possibly improving the 'Setting up AI:MMO on Linux part' Comments from Reviewable |
Review status: 4 of 6 files reviewed, 1 unresolved discussion (waiting on @mrniket and @riaJha97) ubuntu_setup.sh, line 1 at r1 (raw file): Previously, mrniket (Niket Shah) wrote…
Added ref to this script in usage.md Comments from Reviewable |
Reviewed 4 of 5 files at r1, 2 of 2 files at r2. Comments from Reviewable |
Review status: all files reviewed, 1 unresolved discussion (waiting on @mrniket) Comments from Reviewable |
Review status: all files reviewed, 2 unresolved discussions (waiting on @mrniket and @riaJha97) docs/usage.md, line 12 at r2 (raw file):
should we say it's for linux? Comments from Reviewable |
Dismissed @mrniket from a discussion. Comments from Reviewable |
This reverts commit 91b31bc.
* Revert Vagrant #624 changes. Fixes #649 This reverts commit b957777. Revert "Remove Vagrant option from runner (#644)" This reverts commit 91b31bc. Further minor changes. Fixes #649 * Clean up revert changes. Adds pipfile back in and removes vagrantfile Pip docs back to normal Delete Vagrantfile Copy the old Pipfile.lock in More cleanup after reverting * add kubectl to docs * refactor restart_pods to be <26 lines 💪 * python <3 whitespace * newline * Minor comment change to be more clear
This change is![Reviewable](https://camo.githubusercontent.com/23b05f5fb48215c989e92cc44cf6512512d083132bd3daf689867c8d9d386888/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)