Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Vagrant option from runner #644

Merged
merged 4 commits into from
Jun 28, 2018
Merged

Remove Vagrant option from runner #644

merged 4 commits into from
Jun 28, 2018

Conversation

riaJha97
Copy link
Contributor

@riaJha97 riaJha97 commented Jun 27, 2018

This change is Reviewable

@mrniket
Copy link
Contributor

mrniket commented Jun 27, 2018

Reviewed 5 of 5 files at r1.
Review status: all files reviewed, 1 unresolved discussion (waiting on @riaJha97)


ubuntu_setup.sh, line 1 at r1 (raw file):

apt-get update

could be add something in our docs to refer people to this script?


Comments from Reviewable

@riaJha97
Copy link
Contributor Author

Review status: 4 of 5 files reviewed, 1 unresolved discussion (waiting on @mrniket and @riaJha97)


ubuntu_setup.sh, line 1 at r1 (raw file):

Previously, mrniket (Niket Shah) wrote…

could be add something in our docs to refer people to this script?

Not too sure where it should go. Shall I just link to this script in the README or should it be another section in usage.md?


Comments from Reviewable

@mrniket
Copy link
Contributor

mrniket commented Jun 27, 2018

Review status: 4 of 5 files reviewed, 1 unresolved discussion (waiting on @mrniket)


ubuntu_setup.sh, line 1 at r1 (raw file):

Previously, riaJha97 wrote…

Not too sure where it should go. Shall I just link to this script in the README or should it be another section in usage.md?

I would link to the script in the readme, possibly improving the 'Setting up AI:MMO on Linux part'


Comments from Reviewable

@riaJha97
Copy link
Contributor Author

Review status: 4 of 6 files reviewed, 1 unresolved discussion (waiting on @mrniket and @riaJha97)


ubuntu_setup.sh, line 1 at r1 (raw file):

Previously, mrniket (Niket Shah) wrote…

I would link to the script in the readme, possibly improving the 'Setting up AI:MMO on Linux part'

Added ref to this script in usage.md


Comments from Reviewable

@CelineBoudier
Copy link
Contributor

Reviewed 4 of 5 files at r1, 2 of 2 files at r2.
Review status: all files reviewed, 1 unresolved discussion (waiting on @mrniket)


Comments from Reviewable

@CelineBoudier
Copy link
Contributor

:lgtm:


Review status: all files reviewed, 1 unresolved discussion (waiting on @mrniket)


Comments from Reviewable

@CelineBoudier
Copy link
Contributor

Review status: all files reviewed, 2 unresolved discussions (waiting on @mrniket and @riaJha97)


docs/usage.md, line 12 at r2 (raw file):

* Follow the instructions at [game frontend documentation](https://github.com/ocadotechnology/aimmo/blob/master/game_frontend/README.md) in order to install all the frontend requirements.
* Make and activate a virtualenv (We recommend [pipenv](https://docs.pipenv.org/)) - if you have a **[Mac see the section at the bottom](https://github.com/ocadotechnology/aimmo/blob/master/docs/usage.md#on-mac)**.
    * To set this up, run `./ubuntu_setup.sh`. This will install nodejs, yarn, as well as pipenv. 

should we say it's for linux?


Comments from Reviewable

@CelineBoudier
Copy link
Contributor

Dismissed @mrniket from a discussion.
Review status: all files reviewed, 1 unresolved discussion


Comments from Reviewable

@CelineBoudier CelineBoudier merged commit 91b31bc into master Jun 28, 2018
@CelineBoudier CelineBoudier deleted the remove_vagrant branch June 28, 2018 13:29
OlafSzmidt added a commit that referenced this pull request Jul 5, 2018
OlafSzmidt added a commit that referenced this pull request Jul 5, 2018
This reverts commit b957777.
Revert "Remove Vagrant option from runner (#644)"

This reverts commit 91b31bc.
Further minor changes. Fixes #649
CelineBoudier pushed a commit that referenced this pull request Jul 6, 2018
* Revert Vagrant #624 changes. Fixes #649

This reverts commit b957777.
Revert "Remove Vagrant option from runner (#644)"

This reverts commit 91b31bc.
Further minor changes. Fixes #649

* Clean up revert changes. Adds pipfile back in and removes vagrantfile

Pip docs back to normal


Delete Vagrantfile


Copy the old Pipfile.lock in


More cleanup after reverting

* add kubectl to docs

* refactor restart_pods to be <26 lines 💪

* python <3 whitespace

* newline

* Minor comment change to be more clear
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants