Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Now catch any serialise errors #697

Merged
merged 2 commits into from
Jul 31, 2018
Merged

Now catch any serialise errors #697

merged 2 commits into from
Jul 31, 2018

Conversation

NiallEgan
Copy link
Contributor

@NiallEgan NiallEgan commented Jul 31, 2018 •
edited by OlafSzmidt
Loading

Fixes #696

This change is Reviewable

OlafSzmidt
OlafSzmidt approved these changes Jul 31, 2018
View reviewed changes
Copy link
Contributor

@OlafSzmidt OlafSzmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, :lgtm:

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

OlafSzmidt
OlafSzmidt approved these changes Jul 31, 2018
View reviewed changes
Copy link
Contributor

@OlafSzmidt OlafSzmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@NiallEgan NiallEgan merged commit 0f78d1e into master Jul 31, 2018
@NiallEgan NiallEgan deleted the fix_serialise_errors branch July 31, 2018 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OlafSzmidt OlafSzmidt OlafSzmidt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@NiallEgan @OlafSzmidt