Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated pipfile.lock #708

Merged
merged 1 commit into from
Aug 6, 2018
Merged

Updated pipfile.lock #708

merged 1 commit into from
Aug 6, 2018

Conversation

NiallEgan
Copy link
Contributor

@NiallEgan NiallEgan commented Aug 2, 2018

I regenerated the Pipfile.lock using pipenv lock command. I think we should be more careful in future to ensure that the lock does not get out of date.


This change is Reviewable

@NiallEgan NiallEgan requested a review from mrniket August 2, 2018 15:56
Copy link
Contributor

@riaJha97 riaJha97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @NiallEgan and @mrniket)


Pipfile, line 9 at r1 (raw file):


[packages]
"e1839a8" = {editable = true, path = "."}

Was the order an issue before?

Copy link
Contributor

@OlafSzmidt OlafSzmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: Should this perhaps be automatic in our deployment pipelines?

Reviewed 2 of 2 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @NiallEgan and @mrniket)

@NiallEgan NiallEgan removed the request for review from mrniket August 5, 2018 11:32
Copy link
Contributor Author

@NiallEgan NiallEgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am looking in to this, but is complicated because of the way we are currently deploying aimmo, portal and rr.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @NiallEgan)


Pipfile, line 9 at r1 (raw file):

Previously, riaJha97 wrote…

Was the order an issue before?

No, this was randomly changed when I regenerated the Pipfile.

Copy link
Contributor

@OlafSzmidt OlafSzmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @riaJha97)

@NiallEgan NiallEgan merged commit 77e09d6 into master Aug 6, 2018
@NiallEgan NiallEgan deleted the update_pipfile_lock branch August 6, 2018 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants