-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix avatar marker #721
Fix avatar marker #721
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 7 files at r1.
Reviewable status: 1 of 7 files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 6 of 7 files at r1.
Reviewable status: 6 of 7 files reviewed, 3 unresolved discussions (waiting on @riaJha97)
game_frontend/src/redux/features/Game/actions.js, line 54 at r1 (raw file):
) const avatarIdSet = () => (
maybe something more inline with the naming convention we have is UNITY_SEND_AVATAR_ID_SUCCESS
and UNITY_SEND_AVATAR_ID_FAIL
? And the corresponding action names :)
game_frontend/src/redux/features/Game/epics.test.js, line 157 at r1 (raw file):
}) // rewriting connect to game epic test
we can get rid of this comment :)
game_frontend/src/redux/features/Game/epics.test.js, line 242 at r1 (raw file):
game: { connectionParameters: { // game_id
we can get rid of this comment :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 3 of 7 files reviewed, 3 unresolved discussions (waiting on @mrniket)
game_frontend/src/redux/features/Game/actions.js, line 54 at r1 (raw file):
Previously, mrniket (Niket Shah) wrote…
maybe something more inline with the naming convention we have is
UNITY_SEND_AVATAR_ID_SUCCESS
andUNITY_SEND_AVATAR_ID_FAIL
? And the corresponding action names :)
Done
game_frontend/src/redux/features/Game/epics.test.js, line 157 at r1 (raw file):
Previously, mrniket (Niket Shah) wrote…
we can get rid of this comment :)
Done
game_frontend/src/redux/features/Game/epics.test.js, line 242 at r1 (raw file):
Previously, mrniket (Niket Shah) wrote…
we can get rid of this comment :)
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 7 of 7 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved
This PR separates the connectToGameEpic that we had initially into two.
One of the epics forms a socket connection as before and the other one sends the avatar_id from connection parameters to Unity
This change is![Reviewable](https://camo.githubusercontent.com/23b05f5fb48215c989e92cc44cf6512512d083132bd3daf689867c8d9d386888/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)