Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix avatar marker #721

Merged
merged 10 commits into from
Aug 13, 2018
Merged

Fix avatar marker #721

merged 10 commits into from
Aug 13, 2018

Conversation

riaJha97
Copy link
Contributor

@riaJha97 riaJha97 commented Aug 13, 2018

This PR separates the connectToGameEpic that we had initially into two.
One of the epics forms a socket connection as before and the other one sends the avatar_id from connection parameters to Unity

This change is Reviewable

Copy link
Contributor

@NiallEgan NiallEgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 7 files at r1.
Reviewable status: 1 of 7 files reviewed, all discussions resolved

Copy link
Contributor

@mrniket mrniket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 7 files at r1.
Reviewable status: 6 of 7 files reviewed, 3 unresolved discussions (waiting on @riaJha97)


game_frontend/src/redux/features/Game/actions.js, line 54 at r1 (raw file):

)

const avatarIdSet = () => (

maybe something more inline with the naming convention we have is UNITY_SEND_AVATAR_ID_SUCCESS and UNITY_SEND_AVATAR_ID_FAIL? And the corresponding action names :)


game_frontend/src/redux/features/Game/epics.test.js, line 157 at r1 (raw file):

})

// rewriting connect to game epic test

we can get rid of this comment :)


game_frontend/src/redux/features/Game/epics.test.js, line 242 at r1 (raw file):

      game: {
        connectionParameters: {
        // game_id

we can get rid of this comment :)

Copy link
Contributor Author

@riaJha97 riaJha97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 3 of 7 files reviewed, 3 unresolved discussions (waiting on @mrniket)


game_frontend/src/redux/features/Game/actions.js, line 54 at r1 (raw file):

Previously, mrniket (Niket Shah) wrote…

maybe something more inline with the naming convention we have is UNITY_SEND_AVATAR_ID_SUCCESS and UNITY_SEND_AVATAR_ID_FAIL? And the corresponding action names :)

Done


game_frontend/src/redux/features/Game/epics.test.js, line 157 at r1 (raw file):

Previously, mrniket (Niket Shah) wrote…

we can get rid of this comment :)

Done


game_frontend/src/redux/features/Game/epics.test.js, line 242 at r1 (raw file):

Previously, mrniket (Niket Shah) wrote…

we can get rid of this comment :)

Done

Copy link
Contributor

@mrniket mrniket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 7 of 7 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@riaJha97 riaJha97 merged commit 0d1f5bb into master Aug 13, 2018
@riaJha97 riaJha97 deleted the avatar_marker branch August 13, 2018 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants