Changed get_avatar_id_from_user_id() to get_avatar_id_from_user() #779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NiallEgan
approved these changes
Sep 3, 2018
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
NiallEgan
approved these changes
Sep 3, 2018
There was a problem hiding this comment.
Reviewable status:
NiallEgan
suggested changes
Sep 3, 2018
There was a problem hiding this comment.
Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @NiallEgan and @riaJha97)
aimmo/views.py, line 200 at r2 (raw file):
try: avatar_id = game_renderer.get_avatar_id_from_user(user=request.user, game_id=game_id)
Shouldn't the arguments align?
NiallEgan
approved these changes
Sep 3, 2018
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, 1 of 1 files at r3.
Reviewable status:
NiallEgan
approved these changes
Sep 3, 2018
There was a problem hiding this comment.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function get_avatar_id_from_user_id() is passing in a user_id to can_user_play() but this function requires a User object.
This change is