-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pipfile containers #794
Pipfile containers #794
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 14 files reviewed, 1 unresolved discussion (waiting on @NiallEgan)
aimmo-game/Dockerfile, line 7 at r1 (raw file):
ENV WORKER_MANAGER=kubernetes COPY . .
What's this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 14 files reviewed, 1 unresolved discussion (waiting on @NiallEgan)
aimmo-game/Dockerfile, line 7 at r1 (raw file):
Previously, OlafSzmidt (Olaf Szmidt) wrote…
What's this?
This is needed to copy the directory into the image. This was previously done implicitly because we were using python:2-onbuild
as the base image which did all of that stuff for us
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 12 of 14 files at r1.
Reviewable status: 12 of 14 files reviewed, 1 unresolved discussion (waiting on @NiallEgan)
aimmo-game-creator/setup.py, line 11 at r1 (raw file):
install_requires=[ 'eventlet', 'kubernetes >= 6.0.0'
do we not want to fix this at a particular version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 14 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @NiallEgan)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @NiallEgan)
aimmo-game-creator/setup.py, line 11 at r1 (raw file):
Previously, JCobbles (Jacob Moss) wrote…
do we not want to fix this at a particular version?
This wasn't done previously; if we do it should be in a separate PR.
Fixes #793
This change is![Reviewable](https://camo.githubusercontent.com/23b05f5fb48215c989e92cc44cf6512512d083132bd3daf689867c8d9d386888/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)