Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipfile containers #794

Merged
merged 4 commits into from
Sep 7, 2018
Merged

Pipfile containers #794

merged 4 commits into from
Sep 7, 2018

Conversation

NiallEgan
Copy link
Contributor

@NiallEgan NiallEgan commented Sep 5, 2018

Fixes #793


This change is Reviewable

Copy link
Contributor

@OlafSzmidt OlafSzmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 14 files reviewed, 1 unresolved discussion (waiting on @NiallEgan)


aimmo-game/Dockerfile, line 7 at r1 (raw file):

ENV WORKER_MANAGER=kubernetes

COPY . .

What's this?

Copy link
Contributor Author

@NiallEgan NiallEgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 14 files reviewed, 1 unresolved discussion (waiting on @NiallEgan)


aimmo-game/Dockerfile, line 7 at r1 (raw file):

Previously, OlafSzmidt (Olaf Szmidt) wrote…

What's this?

This is needed to copy the directory into the image. This was previously done implicitly because we were using python:2-onbuild as the base image which did all of that stuff for us

Copy link
Contributor

@mossjacob mossjacob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 12 of 14 files at r1.
Reviewable status: 12 of 14 files reviewed, 1 unresolved discussion (waiting on @NiallEgan)


aimmo-game-creator/setup.py, line 11 at r1 (raw file):

    install_requires=[
        'eventlet',
        'kubernetes >= 6.0.0'

do we not want to fix this at a particular version?

Copy link
Contributor

@mossjacob mossjacob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 14 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @NiallEgan)

Copy link
Contributor Author

@NiallEgan NiallEgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @NiallEgan)


aimmo-game-creator/setup.py, line 11 at r1 (raw file):

Previously, JCobbles (Jacob Moss) wrote…

do we not want to fix this at a particular version?

This wasn't done previously; if we do it should be in a separate PR.

@NiallEgan NiallEgan merged commit 35f275d into master Sep 7, 2018
@NiallEgan NiallEgan deleted the pipfile_containers branch September 7, 2018 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants