Pipfile containers #794
Pipfile containers #794
Conversation
There was a problem hiding this comment.
Reviewable status: 0 of 14 files reviewed, 1 unresolved discussion (waiting on @NiallEgan)
aimmo-game/Dockerfile, line 7 at r1 (raw file):
ENV WORKER_MANAGER=kubernetes COPY . .
What's this?
There was a problem hiding this comment.
Reviewable status: 0 of 14 files reviewed, 1 unresolved discussion (waiting on @NiallEgan)
aimmo-game/Dockerfile, line 7 at r1 (raw file):
Previously, OlafSzmidt (Olaf Szmidt) wrote…
What's this?
This is needed to copy the directory into the image. This was previously done implicitly because we were using python:2-onbuild as the base image which did all of that stuff for us
There was a problem hiding this comment.
Reviewed 12 of 14 files at r1.
Reviewable status: 12 of 14 files reviewed, 1 unresolved discussion (waiting on @NiallEgan)
aimmo-game-creator/setup.py, line 11 at r1 (raw file):
install_requires=[ 'eventlet', 'kubernetes >= 6.0.0'
do we not want to fix this at a particular version?
There was a problem hiding this comment.
Reviewed 2 of 14 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @NiallEgan)
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @NiallEgan)
aimmo-game-creator/setup.py, line 11 at r1 (raw file):
Previously, JCobbles (Jacob Moss) wrote…
do we not want to fix this at a particular version?
This wasn't done previously; if we do it should be in a separate PR.
Fixes #793
This change is