Remove non user code traceback

[TheseusGrey]

Formatted traceback so the user's console only shows output relevant to their code.

---

This change is 

[NiallEgan]

I think we could do with a third test, one which tests if the traceback is fine if they return None etc.

Reviewable status: 0 of 2 files reviewed, 6 unresolved discussions (waiting on @dent50cent)

---

aimmo-game-worker/avatar_runner.py, line 48 at r1 (raw file):

        except InvalidActionException as e:
            print(str(e))

I think that if you call print then str will be automatically called, so maybe the str is redundant? Also maybe we should have a comment explaining why we have a separate except?

---

aimmo-game-worker/avatar_runner.py, line 75 at r1 (raw file):

        return action.serialise()

    def format_user_traceback(self, tb_list):

This can be a static method

---

aimmo-game-worker/avatar_runner.py, line 75 at r1 (raw file):

        return action.serialise()

    def format_user_traceback(self, tb_list):

I think a better name would be something like get_only_user_traceback?

---

aimmo-game-worker/avatar_runner.py, line 78 at r1 (raw file):

        start_of_user_traceback = 0
        for i in range(len(tb_list)):
            if tb_list[i].__contains__('<string>'):

I think you should use the in keyword here. In general, you shouldn't invoke magic methods directly, use in, +, or etc

---

aimmo-game-worker/tests/test_avatar_runner.py, line 132 at r1 (raw file):

        runner = AvatarRunner()
        response = runner.process_avatar_turn(world_map={}, avatar_state={}, src_code=avatar)
        self.assertFalse(response['log'].__contains__('/usr/src/app/'))

__contains__

---

aimmo-game-worker/tests/test_avatar_runner.py, line 145 at r1 (raw file):

        runner = AvatarRunner()
        response = runner.process_avatar_turn(world_map={}, avatar_state={}, src_code=avatar)
        self.assertFalse(response['log'].__contains__('/usr/src/app/'))

__contains__

[CelineBoudier]

I'd suggest to try to briefly describe the sort of "various"/ "more" changes as it is a bit easier to review

Reviewable status: 0 of 2 files reviewed, 6 unresolved discussions (waiting on @dent50cent)

[TheseusGrey]

Reviewable status: 0 of 2 files reviewed, 6 unresolved discussions (waiting on @dent50cent and @NiallEgan)

---

aimmo-game-worker/avatar_runner.py, line 48 at r1 (raw file):

Previously, NiallEgan (Niall Egan) wrote…

I think that if you call print then str will be automatically called, so maybe the str is redundant? Also maybe we should have a comment explaining why we have a separate except?

These have been fixed, the examples i found when writing the code were for python 2.5 or lower, did more research and found it had be fixed for python 2.6. Added comment explaining the addition except.

---

aimmo-game-worker/avatar_runner.py, line 75 at r1 (raw file):

Previously, NiallEgan (Niall Egan) wrote…

This can be a static method

Done.

---

aimmo-game-worker/avatar_runner.py, line 75 at r1 (raw file):

Previously, NiallEgan (Niall Egan) wrote…

I think a better name would be something like get_only_user_traceback?

Done

---

aimmo-game-worker/avatar_runner.py, line 78 at r1 (raw file):

Previously, NiallEgan (Niall Egan) wrote…

I think you should use the in keyword here. In general, you shouldn't invoke magic methods directly, use in, +, or etc

Done

---

aimmo-game-worker/tests/test_avatar_runner.py, line 132 at r1 (raw file):

Previously, NiallEgan (Niall Egan) wrote…

__contains__

Done.

---

aimmo-game-worker/tests/test_avatar_runner.py, line 145 at r1 (raw file):

Previously, NiallEgan (Niall Egan) wrote…

__contains__

Done.

[NiallEgan]

Reviewed 2 of 2 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved

[NiallEgan]

Reviewable status: complete! all files reviewed, all discussions resolved

[NiallEgan]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dent50cent)

---

aimmo-game-worker/avatar_runner.py, line 55 at r2 (raw file):

        except Exception as e:
            traceback_list = traceback.format_exc().split('\n')

Maybe this should be in get_only_user_traceback?

[TheseusGrey]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @NiallEgan)

---

aimmo-game-worker/avatar_runner.py, line 55 at r2 (raw file):

Previously, NiallEgan (Niall Egan) wrote…

Maybe this should be in get_only_user_traceback?

Done

[NiallEgan]

Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @NiallEgan and @dent50cent)

---

aimmo-game-worker/avatar_runner.py, line 77 at r3 (raw file):

    @staticmethod
    def get_only_user_traceback(e):

Do we have to pass e in here?

[TheseusGrey]

Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @NiallEgan and @dent50cent)

---

aimmo-game-worker/avatar_runner.py, line 77 at r3 (raw file):

Previously, NiallEgan (Niall Egan) wrote…

Do we have to pass e in here?

no, this has been fixed.

[NiallEgan]

Reviewed 1 of 1 files at r3, 1 of 1 files at r4.
Reviewable status: complete! all files reviewed, all discussions resolved