-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Snackbar for Avatar code updated feedback #799
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 8 of 26 files at r1.
Reviewable status: 8 of 26 files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 18 of 26 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @mrniket)
game_frontend/src/testHelpers/createShallow.js, line 7 at r1 (raw file):
const light = ThemeProvider.createTheme('light') const dark = ThemeProvider.createTheme('dark') const themeVariants = { light, dark }
Is it needed for you to store the themes to their own variables before adding them to themeVariants?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 23 of 26 files reviewed, 1 unresolved discussion (waiting on @NiallEgan, @dent50cent, and @mrniket)
game_frontend/src/testHelpers/createShallow.js, line 7 at r1 (raw file):
Previously, dent50cent wrote…
Is it needed for you to store the themes to their own variables before adding them to themeVariants?
It's not needed but it's an optimisation as it will stop the theme being generated for every test that needs one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 23 of 26 files reviewed, 1 unresolved discussion (waiting on @NiallEgan and @dent50cent)
game_frontend/src/testHelpers/createShallow.js, line 7 at r1 (raw file):
Previously, mrniket (Niket Shah) wrote…
It's not needed but it's an optimisation as it will stop the theme being generated for every test that needs one
:OK:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @mrniket)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 21 of 26 files at r1, 2 of 3 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @mrniket)
…f components No simple way to compose context
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 8 files at r3.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @mrniket)
game_frontend/src/containers/IDE/index.js, line 33 at r3 (raw file):
</MuiThemeProvider> </StyledComponentsThemeProvider> )
Do you need to specify the theme for both the MuiThemeProvider
and StyledComponentsThemeProvider
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @mrniket)
game_frontend/src/containers/IDE/index.js, line 33 at r3 (raw file):
Previously, dent50cent wrote…
Do you need to specify the theme for both the
MuiThemeProvider
andStyledComponentsThemeProvider
?
Yeah, the providers are from two different libraries (material-ui and styled-components) and as such are independent of each other
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 26 files at r1, 1 of 3 files at r2, 5 of 8 files at r3.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @mrniket and @dent50cent)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status:
complete! all files reviewed, all discussions resolved
Notable changes:
createShallowWithTheme
has been modified to allow testing of the Snackbar and handle the two themesThis change is![Reviewable](https://camo.githubusercontent.com/23b05f5fb48215c989e92cc44cf6512512d083132bd3daf689867c8d9d386888/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)