Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ubuntu setup script fix #802

Merged
merged 1 commit into from
Sep 10, 2018
Merged

Ubuntu setup script fix #802

merged 1 commit into from
Sep 10, 2018

Conversation

OlafSzmidt
Copy link
Contributor

@OlafSzmidt OlafSzmidt commented Sep 9, 2018 •
edited
Loading

Minor fix which confused cmdtest with yarn. More info in #801.

This change is Reviewable

@OlafSzmidt OlafSzmidt added the bug label Sep 9, 2018
@OlafSzmidt OlafSzmidt added this to the Sprint 69 - PyPrep milestone Sep 9, 2018
@OlafSzmidt OlafSzmidt self-assigned this Sep 9, 2018
@OlafSzmidt OlafSzmidt removed this from the Sprint 69 - PyPrep milestone Sep 9, 2018
riaJha97
riaJha97 approved these changes Sep 10, 2018
View reviewed changes
Copy link
Contributor

@riaJha97 riaJha97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this issue specific to ubuntu 18.04?

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @OlafSzmidt)

OlafSzmidt
OlafSzmidt commented Sep 10, 2018
View reviewed changes
Copy link
Contributor Author

@OlafSzmidt OlafSzmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Specific to Ubuntu 17+ where cmdtest gets installed by default, but also to all other systems that may have it installed already

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @OlafSzmidt)

riaJha97
riaJha97 approved these changes Sep 10, 2018
View reviewed changes
Copy link
Contributor

@riaJha97 riaJha97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you still have the rights to merge?

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @OlafSzmidt)

riaJha97
riaJha97 approved these changes Sep 10, 2018
View reviewed changes
Copy link
Contributor

@riaJha97 riaJha97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @OlafSzmidt)

@OlafSzmidt OlafSzmidt merged commit 9dcb9a4 into master Sep 10, 2018
@OlafSzmidt OlafSzmidt deleted the ubuntu_setup branch September 10, 2018 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riaJha97 riaJha97 riaJha97 approved these changes

Assignees

@OlafSzmidt OlafSzmidt

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@OlafSzmidt @riaJha97