This repository has been archived by the owner on Aug 25, 2023. It is now read-only.
YACHT-1142: SLI Quality query finds also tables without backup table … #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in BQ even if datastore has information about backup. Adding additional predicate which prevents from filtering out tables which doesn't have backup table in BigQuery. Additional units tests was added.
radkomateusz
requested review from
marek-tabor,
jarekdrabek,
marcin-kolda and
przemyslaw-jasinski
Pull Request Test Coverage Report for Build 972
💛 - Coveralls |
marek-tabor
approved these changes
Jan 3, 2019
przemyslaw-jasinski
approved these changes
Jan 3, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…in BQ even if datastore has information about backup.
Adding additional predicate which prevents from filtering out tables which doesn't have backup table in BigQuery.
Additional units tests was added.