This repository has been archived by the owner on Aug 25, 2023. It is now read-only.
Yacht-1184: Changed deserialisation method in handlers from PICKLE to JSON #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n_handler and test_after_restore_action_handler
przemyslaw-jasinski
requested review from
marcin-kolda,
jarekdrabek,
MZatorski and
marek-tabor
marek-tabor
approved these changes
Feb 5, 2019
Pull Request Test Coverage Report for Build 1020
💛 - Coveralls |
marcin-kolda
suggested changes
Feb 5, 2019
|
|
||
| @classmethod | ||
| def from_json(cls, json): | ||
| from src.commons.big_query.big_query_job_reference import \ |
There was a problem hiding this comment.
Please move imports to the top
marcin-kolda
approved these changes
Feb 6, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.