This repository has been archived by the owner on Aug 25, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ference and get_table_by_reference_cached to big_query_table_metadata
…commented tests 2
przemyslaw-jasinski
previously approved these changes
Jul 8, 2018
# Conflicts: # src/restore/async_batch_restore_service.py # tests/big_query/test_big_query_table_metadata.py
…xt instead of installing it via travis script itself
radkomateusz
previously approved these changes
Jul 11, 2018
marcin-kolda
suggested changes
Jul 11, 2018
requirements_tests.txt
Outdated
google-cloud-bigquery==0.26.0 | ||
coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please specify versions here
marcin-kolda
suggested changes
Jul 11, 2018
.travis.yml
Outdated
script: | ||
# - find . -name "*.py" -path "./*" -not \( -path "./lib/*" -o -path "./google-cloud-sdk/*" \) | xargs pylint --reports=yes --rcfile=.pylintrc | ||
- PYTHONPATH=$PYTHONPATH:./lib:./google-cloud-sdk/bin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would use build stages here, seems to be very simple :)
https://docs.travis-ci.com/user/build-stages/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
marcin-kolda
approved these changes
Jul 11, 2018
przemyslaw-jasinski
approved these changes
Jul 12, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.