This repository has been archived by the owner on Aug 25, 2023. It is now read-only.
YACHT-1316: Updating retention process to avoid possible situation th… #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…at creating new backup of table, which previous backup has more than 7 months, causes removing previous version of backup. Removing unused code. Adding units tests for all currently known situations.
radkomateusz
requested review from
marcin-kolda,
przemyslaw-jasinski,
jarekdrabek,
MZatorski and
marek-tabor
Pull Request Test Coverage Report for Build 1117
💛 - Coveralls |
…, 10 young backups and there is created 4 new backups in the same day (duplicates). Expectation is that during retention deduplication will happen first, only the newest today version will stay, then as 1+10 =11, 11th, oldest young backup will be removed. Old backup will stay as it was.
marcin-kolda
suggested changes
Apr 15, 2019
| from src.retention.policy.filter.ten_young_backup_versions_filter import \ | ||
| TenYoungBackupVersionsFilter | ||
| from src.retention.policy.filter.only_one_version_above_7_months_filter import \ | ||
| OnlyOneVersionAbove7MonthsFilter | ||
|
|
||
|
|
||
| class Fifo10UpTo7Months(object): |
There was a problem hiding this comment.
Please rename as retention strategy is now more customised
There was a problem hiding this comment.
renamed to RetentionPolicy. done
…he only one retention policy currently implemented and it's now taking more details into consideration than mentioned in previous name.
marcin-kolda
approved these changes
Apr 15, 2019
MZatorski
approved these changes
Apr 15, 2019
przemyslaw-jasinski
pushed a commit
that referenced
this pull request
Apr 23, 2019
YACHT-1316: Updating retention process to avoid possible situation th…
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…at creating new backup of table, which previous backup has more than 7 months, causes removing previous version of backup.
Removing unused code. Adding units tests for all currently known situations.