Skip to content
This repository has been archived by the owner on Aug 25, 2023. It is now read-only.

YACHT-1256: Updating documentation - details about modified retention… #140

Merged
merged 1 commit into from
Apr 18, 2019

Conversation

radkomateusz
Copy link
Contributor

… policy. Gif also updated.

Adding unit test for situation when there is an old backup, then is new change and new backup and then source table is deleted.

@radkomateusz radkomateusz requested review from marcin-kolda and przemyslaw-jasinski and removed request for marcin-kolda April 17, 2019 15:45
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1121

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.284%

Totals Coverage Status
Change from base Build 1119: 0.0%
Covered Lines: 2408
Relevant Lines: 2857

💛 - Coveralls

@coveralls
Copy link

coveralls commented Apr 17, 2019

Pull Request Test Coverage Report for Build 1123

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.284%

Totals Coverage Status
Change from base Build 1119: 0.0%
Covered Lines: 2408
Relevant Lines: 2857

💛 - Coveralls

README.md Outdated
@@ -1,4 +1,5 @@
[![Build Status](https://travis-ci.org/ocadotechnology/bbq.svg?branch=master)](https://travis-ci.org/ocadotechnology/bbq)
[![Build Status](https://travis-ci.org/ocadotechnology/bbq.svg?branch=master)](https://travis-ci.org/ocadotechnology/bbq)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is it twice?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

README.md Outdated
@@ -1,4 +1,5 @@
[![Build Status](https://travis-ci.org/ocadotechnology/bbq.svg?branch=master)](https://travis-ci.org/ocadotechnology/bbq)
[![Build Status](https://travis-ci.org/ocadotechnology/bbq.svg?branch=master)](https://travis-ci.org/ocadotechnology/bbq)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

… policy. Gif also updated.

Adding unit test for situation when there is an old backup, then is new change and new backup and then source table is deleted.
@radkomateusz radkomateusz merged commit 46470a5 into master Apr 18, 2019
@radkomateusz radkomateusz deleted the YACHT-1316 branch April 18, 2019 11:37
przemyslaw-jasinski pushed a commit that referenced this pull request Apr 23, 2019
YACHT-1256: Updating documentation - details about modified retention…
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants