This repository has been archived by the owner on Aug 25, 2023. It is now read-only.
YACHT-1256: Updating SLI latency view to filter out empty tables as i… #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radkomateusz
requested review from
marcin-kolda,
przemyslaw-jasinski,
jarekdrabek and
MZatorski
Pull Request Test Coverage Report for Build 1168
💛 - Coveralls |
marcin-kolda
previously approved these changes
Apr 23, 2019
MZatorski
suggested changes
Apr 23, 2019
terraform/sli/SLI_0_days_views.tf
Outdated
| @@ -18,6 +18,7 @@ resource "google_bigquery_table" "census_data_0_days_ago_view" { | |||
| WHERE | |||
| _PARTITIONTIME BETWEEN TIMESTAMP(DATE_ADD(CURRENT_DATE(), -3, "DAY")) AND TIMESTAMP(CURRENT_DATE()) | |||
| AND timePartitioning.type IS NULL AND type='TABLE' | |||
| AND numRows != 0 | |||
There was a problem hiding this comment.
I'm wondering should we put that condition in the other view (SLI_0_days_view).
radkomateusz
force-pushed
the
YACHT-1256
branch
2 times, most recently
from
6ac5569
to
78e1b66
Compare
…of given table is not empty and lastModification time is newer than date of newest backup
…ness. Adding test: Should make backup if source table is empty and existing backup is also empty (eg. schema change but without adding any data).
…t isn't violation anymore. Adding descriptions for views. Refactoring of terraform dependencies to avoid specifying dependencies explicitly.
radkomateusz
force-pushed
the
YACHT-1256
branch
from
78e1b66
to
0db5e55
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…t isn't violation anymore.