This repository has been archived by the owner on Aug 25, 2023. It is now read-only.
Yacht-1317: Our error reporting system doesn't work #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1177
💛 - Coveralls |
1 similar comment
Pull Request Test Coverage Report for Build 1177
💛 - Coveralls |
przemyslaw-jasinski
requested review from
radkomateusz,
jarekdrabek and
marcin-kolda
and removed request for
radkomateusz
radkomateusz
suggested changes
Apr 25, 2019
| try: | ||
| self.__process(request_body_json) | ||
| self._finish_with_success() | ||
| except CopyJobError, e: |
There was a problem hiding this comment.
I used to think that returning 200 here was intended, because afterBackupActionHandler is not responsible for retrying copyJobs etc.
We were calling ErrorReporting to know that backups finished in not expected way. We want to know about that situation.
I case of this errors, we can't do anything with then, even if we retry whole task again.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.