This repository has been archived by the owner on Aug 25, 2023. It is now read-only.
YACHT-972: Each partition of empty partitioned table is now backed up. #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Earlier, empty but still partitioned table was backes up as not-partitoned one. It caused a bug in situation when earlier partitions (and whole table in consequence was not empty) were not empty, and then after data deletion, BBQ doesn't update each partition, but instead creates new backup of whole table. It makes this backup unrestorable as we assume that at given point of time there shouldn't be any Table entites which has both X:Y.Z$null and X:Y.Z$any_partition entries.
radkomateusz
requested review from
jarekdrabek,
przemyslaw-jasinski,
marcin-kolda and
MZatorski
and removed request for
jarekdrabek
Pull Request Test Coverage Report for Build 438
💛 - Coveralls |
Previously it performs two checks: - if table has daily partitioning set in metadata - if table is not single partition (as single partition has also set daily partitioning) It could produce bugs, as in some cases we could want to know if table is daily partitioned but we don't care if table is single partition or main table. In other cases we want to know if the table is single partition. We decided to divide it to different methods.
…which will cause retry during daily random table restore test in case when partitioned table is without partitions. Update of documentation about the fact that BBQ doesn't backup partitioned tables without any partitions.
marcin-kolda
approved these changes
Aug 21, 2018
jarekdrabek
approved these changes
Aug 21, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier, empty but still partitioned table was backes up as not-partitoned one. It caused a bug in situation when earlier partitions (and whole table in consequence was not empty) were not empty, and then after data deletion, BBQ doesn't update each partition, but instead creates new backup of whole table. It makes this backup unrestorable as we assume that at given point of time there shouldn't be any Table entites which has both X:Y.Z$null and X:Y.Z$any_partition entries.