Skip to content
This repository has been archived by the owner on Aug 25, 2023. It is now read-only.

YACHT-1014: Updated SLI Readme and fixed query in tf file #57

Closed
wants to merge 0 commits into from

Conversation

przemyslaw-jasinski
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Sep 13, 2018

Pull Request Test Coverage Report for Build 616

  • 6 of 7 (85.71%) changed or added relevant lines in 1 file are covered.
  • 9 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+1.7%) to 80.792%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/slo/x_days_sli/x_days_sli_service.py 6 7 85.71%
Files with Coverage Reduction New Missed Lines %
src/backup/copy_job_async/copy_job/copy_job_service.py 2 95.12%
src/commons/big_query/streaming/data_streamer.py 7 62.07%
Totals Coverage Status
Change from base Build 604: 1.7%
Covered Lines: 2284
Relevant Lines: 2827

💛 - Coveralls

SLI_README.md Outdated

This metric is measuring number of tables which last available backup does not contain the same data as source.

Metric is implemented as a BigQuery query, which list all tables and joins them with last available backup using [Cloud Datastore export](./SETUP.md#cloud-datastore-export) and then compare the number of bytes and rows between source table and its backup (collected by Census).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add information that we are verifying tables not changed for at least 3 days

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants