This repository has been archived by the owner on Aug 25, 2023. It is now read-only.
YACHT-1026: partitions that have no backups were filter out in SLI queries - fix #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcin-kolda
suggested changes
Sep 17, 2018
terraform/SLI_3_days_views.tf
Outdated
| @@ -71,7 +71,7 @@ resource "google_bigquery_table" "SLI_3_days_view" { | |||
| census.datasetId=last_backups.source_dataset_id AND | |||
| census.tableId=last_backups.source_table_id | |||
| WHERE | |||
| IFNULL(census.partitionId, 'null')=IFNULL(last_backups.source_partition_id, 'null') | |||
| (census.partitionId=last_backups.source_partition_id OR last_backups.source_partition_id IS NULL) | |||
There was a problem hiding this comment.
I would invert the equal statement so that it's easier to read, i.e.:
(last_backups.source_partition_id=census.partitionId OR last_backups.source_partition_id IS NULL)
radkomateusz
previously approved these changes
Sep 17, 2018
…eries - small reading improvement
…eries - small reading improvement2
marcin-kolda
approved these changes
Sep 17, 2018
radkomateusz
approved these changes
Sep 17, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.