This repository has been archived by the owner on Aug 25, 2023. It is now read-only.
NON-JIRA: Snapshot time is now the same for all vulnerabilities comin… #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g from one query instead of having different snapshot times for each row. View is querying for tables from newest available snapshot (which is the same) for each xDays now. View assume that 1st change is done. Still it doesn't resolve situation when there are some vulnerabilites in first snapshot but any vulnerabilities was found in next - it still shows vulnerabilities from 1st snapshot - they will dissappear next day.
radkomateusz
requested review from
marcin-kolda,
przemyslaw-jasinski,
jarekdrabek and
MZatorski
Pull Request Test Coverage Report for Build 697
💛 - Coveralls |
marcin-kolda
suggested changes
Sep 25, 2018
…is populated to SLI_backup_creation_latency table and then filtered out by SLI_backup_creation_latency_view which is using by our dashboard. It allows us to show SLI improvements without waiting for next day (creating new partition). Now possible improvements will be shown by view at the next SLO query at the same day.
jarekdrabek
previously approved these changes
Sep 26, 2018
…ows_rows_only_from_newest_snapshot # Conflicts: # src/slo/x_days_sli/sli_view_querier.py
jarekdrabek
approved these changes
Sep 26, 2018
przemyslaw-jasinski
approved these changes
Sep 26, 2018
przemyslaw-jasinski
deleted the
SLI_history_view_shows_rows_only_from_newest_snapshot
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…g from one query instead of having different snapshot times for each row.
View is querying for tables from newest available snapshot (which is the same) for each xDays now.
View assume that 1st change is done.
Still it doesn't resolve situation when there are some vulnerabilites in first snapshot but any vulnerabilities was found in next - it still shows vulnerabilities from 1st snapshot - they will dissappear next day.