This repository has been archived by the owner on Aug 25, 2023. It is now read-only.
Setup update y903 #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing config/cron entries which doesn't have sense without proper test environment.
radkomateusz
requested review from
przemyslaw-jasinski,
marcin-kolda and
jarekdrabek
marcin-kolda
suggested changes
Jul 4, 2018
SETUP.md
Outdated
|
|
||
| <a href="https://console.cloud.google.com/cloudshell/open?git_repo=https://github.com/ocadotechnology/bbq&page=editor&open_in_editor=SETUP.md"> | ||
| <img alt="Open in Cloud Shell" src ="http://gstatic.com/cloudssh/images/open-btn.png"></a> | ||
| ##### The easiest way is to use Google Cloud Shell - click button below. It opens your Google Cloud Shell and clones the repository. |
SETUP.md
Outdated
| ##### The easiest way is to use Google Cloud Shell - click button below. It opens your Google Cloud Shell and clones the repository. | ||
| [](https://console.cloud.google.com/cloudshell/open?git_repo=https%3A%2F%2Fgithub.com%2Focadotechnology%2Fbbq&page=shell&tutorial=SETUP.md) | ||
| * It is possible to do it from local environment. But it requires installing Google Cloud SDK for Python (see at [installing Cloud SDK for Python](https://cloud.google.com/appengine/docs/standard/python/download)) |
There was a problem hiding this comment.
Don't start a sentence with "but", just add the comma.
There was a problem hiding this comment.
Remove also "*" in the beginning as single list is confusing.
SETUP.md
Outdated
| <br> | ||
|
|
||
| * Note: It is possible to do it from local environment. But it requires installing Google Cloud SDK for Python (see at [installing Cloud SDK for Python](https://cloud.google.com/appengine/docs/standard/python/download)) | ||
| 1. Instruction assumes that you are the owner of two GCP projects. |
There was a problem hiding this comment.
"1. Create and enable billing to two GCP projects"?
SETUP.md
Outdated
| * **custom_project_list** - list of projects to backup. If empty, BBQ will backup everything it has read (**BigQuery Data Viewer**) access to. If list is provided you still need to grant **BigQuery Data Viewer** role for BBQ service account for each mentioned projects. | ||
| * **projects_to_skip** - list of projects to skip (it's recommended to skip BBQ project itself). It is useful when you grant **BigQuery Data Viewer** for BBQ service account for the whole organization or folder and want to exclude some of the projects. | ||
| * **backup_project_id** - project id where backups will be stored (it can also be the same project on which BBQ runs) | ||
| * **restoration_project_id** - project into which data will be restored by default (you can also define restoration destination directly while executing restoration) | ||
| * **backup_project_id** - project id where backups will be stored (it ussualy is the same project on which BBQ runs) |
config/config.yaml
Outdated
|
|
||
| project_settings: | ||
| backup_project_id: '<your-project-id>' | ||
| restoration_project_id: '<your-project-id>' | ||
| backup_project_id: '<your-project-id-for-BBQ-project>' #project id where backups will be stored (it ussualy is the same project on which BBQ runs) |
config/config.yaml
Outdated
| @@ -3,12 +3,14 @@ copy_jobs: | |||
|
|
|||
| backup_settings: | |||
| backup_worker_max_countdown_in_sec: 0 | |||
| custom_project_list: [] | |||
| projects_to_skip: ['<your-project-id>'] | |||
| custom_project_list: [] #list of projects to backup. If empty, BBQ will backup everything it has read (BigQuery Data Viewer) access to. If list is provided you still need to grant BigQuery Data Viewer role for BBQ service account for each mentioned projects. | |||
There was a problem hiding this comment.
What do you think about describing fields line before? It's hard to read such long lines
marcin-kolda
approved these changes
Jul 4, 2018
przemyslaw-jasinski
approved these changes
Jul 4, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.