-
Notifications
You must be signed in to change notification settings - Fork 7
Conversation
Removing config/cron entries which doesn't have sense without proper test environment.
SETUP.md
Outdated
|
||
<a href="https://console.cloud.google.com/cloudshell/open?git_repo=https://github.com/ocadotechnology/bbq&page=editor&open_in_editor=SETUP.md"> | ||
<img alt="Open in Cloud Shell" src ="http://gstatic.com/cloudssh/images/open-btn.png"></a> | ||
##### The easiest way is to use Google Cloud Shell - click button below. It opens your Google Cloud Shell and clones the repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Recommended way"?
SETUP.md
Outdated
##### The easiest way is to use Google Cloud Shell - click button below. It opens your Google Cloud Shell and clones the repository. | ||
[![Open in Cloud Shell](http://gstatic.com/cloudssh/images/open-btn.svg)](https://console.cloud.google.com/cloudshell/open?git_repo=https%3A%2F%2Fgithub.com%2Focadotechnology%2Fbbq&page=shell&tutorial=SETUP.md) | ||
* It is possible to do it from local environment. But it requires installing Google Cloud SDK for Python (see at [installing Cloud SDK for Python](https://cloud.google.com/appengine/docs/standard/python/download)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't start a sentence with "but", just add the comma.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove also "*" in the beginning as single list is confusing.
SETUP.md
Outdated
<br> | ||
|
||
* Note: It is possible to do it from local environment. But it requires installing Google Cloud SDK for Python (see at [installing Cloud SDK for Python](https://cloud.google.com/appengine/docs/standard/python/download)) | ||
1. Instruction assumes that you are the owner of two GCP projects. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"1. Create and enable billing to two GCP projects"?
SETUP.md
Outdated
* **custom_project_list** - list of projects to backup. If empty, BBQ will backup everything it has read (**BigQuery Data Viewer**) access to. If list is provided you still need to grant **BigQuery Data Viewer** role for BBQ service account for each mentioned projects. | ||
* **projects_to_skip** - list of projects to skip (it's recommended to skip BBQ project itself). It is useful when you grant **BigQuery Data Viewer** for BBQ service account for the whole organization or folder and want to exclude some of the projects. | ||
* **backup_project_id** - project id where backups will be stored (it can also be the same project on which BBQ runs) | ||
* **restoration_project_id** - project into which data will be restored by default (you can also define restoration destination directly while executing restoration) | ||
* **backup_project_id** - project id where backups will be stored (it ussualy is the same project on which BBQ runs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: ussualy -> usually
config/config.yaml
Outdated
|
||
project_settings: | ||
backup_project_id: '<your-project-id>' | ||
restoration_project_id: '<your-project-id>' | ||
backup_project_id: '<your-project-id-for-BBQ-project>' #project id where backups will be stored (it ussualy is the same project on which BBQ runs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: ussualy -> usually
config/config.yaml
Outdated
@@ -3,12 +3,14 @@ copy_jobs: | |||
|
|||
backup_settings: | |||
backup_worker_max_countdown_in_sec: 0 | |||
custom_project_list: [] | |||
projects_to_skip: ['<your-project-id>'] | |||
custom_project_list: [] #list of projects to backup. If empty, BBQ will backup everything it has read (BigQuery Data Viewer) access to. If list is provided you still need to grant BigQuery Data Viewer role for BBQ service account for each mentioned projects. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about describing fields line before? It's hard to read such long lines
No description provided.