This repository has been archived by the owner on Aug 25, 2023. It is now read-only.
Restoration daily test fix #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
przemyslaw-jasinski
requested review from
marcin-kolda,
radkomateusz and
jarekdrabek
Pull Request Test Coverage Report for Build 217
💛 - Coveralls |
radkomateusz
previously approved these changes
Jul 4, 2018
marcin-kolda
suggested changes
Jul 4, 2018
| result = RestorationJobStatusService()\ | ||
| .get_restoration_job(restoration_job_id) | ||
|
|
||
| if result["status"]["state"] in "In progress": |
There was a problem hiding this comment.
Periodical retrieving state using exceptions looks really bad. Could you use simple while loop?
marcin-kolda
suggested changes
Jul 5, 2018
| .get_restoration_job(restoration_job_id) | ||
| if result["status"]["state"] in "Done": | ||
| return result | ||
| time.sleep(period) |
There was a problem hiding this comment.
I would log info, how long sleep will take
radkomateusz
approved these changes
Jul 5, 2018
marcin-kolda
approved these changes
Jul 5, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.