Skip to content
This repository has been archived by the owner on Aug 25, 2023. It is now read-only.

YACHT-1111: SLI views corrected #94

Closed
wants to merge 1 commit into from
Closed

YACHT-1111: SLI views corrected #94

wants to merge 1 commit into from

Conversation

jarekdrabek
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Nov 22, 2018

Pull Request Test Coverage Report for Build 864

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 83.311%

Totals Coverage Status
Change from base Build 834: 0.0%
Covered Lines: 2456
Relevant Lines: 2948

💛 - Coveralls

Copy link
Contributor

@marek-tabor marek-tabor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I not sure but consider one thing, if you changed date intervals you should include first one as well.
For example SLI for 7 days, now starts -10 days

@radkomateusz
Copy link
Contributor

That's not resolving a problem. After change you are checking all snapshots between now and 7 days ago -> if table has been changed 7 days ago and then 1 day ago (and both changes was caught by Census snapshots - first 6 days ago, second by today snapshot) and if BBQ failed to backup for that first change, then after this change, it won't occur on our SLI dashboard. (But it should).

@jarekdrabek jarekdrabek deleted the YACHT-1111 branch November 22, 2018 14:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants