This repository has been archived by the owner on Aug 25, 2023. It is now read-only.
Yacht 1104 #98
Merged
Yacht 1104 #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additional handler for those tasks. Added new sli-table-quality-violations queue to config file.
Additional handler for those tasks. Added new sli-table-quality-violations queue to config file. Rewrited tests. Changed a bit logic to stream snapshot_time always after sli_recalculation, even for no tables from query.
Pull Request Test Coverage Report for Build 918
💛 - Coveralls |
przemyslaw-jasinski
suggested changes
Dec 3, 2018
| filtered_tables, | ||
| snapshot_marker=self.__create_snapshot_marker_row(snapshot_time) | ||
| ) | ||
| self.streamer.stream([], snapshot_marker=self.__create_snapshot_marker_row(snapshot_time)) |
There was a problem hiding this comment.
We should change somehow streamer method. It doesn't need an empty array. Same with SliLatencyService.
marcin-kolda
suggested changes
Dec 3, 2018
| self.streamer.stream([], snapshot_marker=self.__create_snapshot_marker_row(snapshot_time)) | ||
| logging.info("Snapshot marker sent %s", snapshot_time) | ||
|
|
||
| def check_and_stream_violation(self, json_data): |
There was a problem hiding this comment.
I would pass a table json instead of wrapper
marcin-kolda
approved these changes
Dec 4, 2018
przemyslaw-jasinski
approved these changes
Dec 4, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.