Add authentication checks to reminder cards page #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks Josh, can you please squash the commits and fix the codeclimate issue? |
joshuablake
force-pushed
the
teacher_login
branch
from
6a305ba
to
934c851
Compare
Adds several security features: - Do not allow teacher's to view the cards for classes they do not have access to. - Return 404 if cards for a class that does not exist are requested (rather than erroring). - Also return 404 if the teacher does not have access to this class (rather than leaking that the class exists). Tests for the above and for the same issues in other views are also included.
joshuablake
force-pushed
the
teacher_login
branch
from
934c851
to
17737bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks that the correct teacher is logged in.
Return the same error code (404) if either the wrong teacher is logged in or if the class the reminder cards are requested for does not exist. This prevents any information being leaked about which classes exist in the database.