-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: z-indexes of top menu, dropdown and subnavs #928
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 4 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @mariaFernando)
portal/templates/portal/base.html, line 363 at r1 (raw file):
$(window).on('scroll', function() { var scroll = $(window).scrollTop(); if ((scroll > 0) && ($('.dropdown').hasClass('open'))) {
I think you can have the if without the inner brackets around scroll > 0
and the other condition
portal/templates/portal/base.html, line 365 at r1 (raw file):
if ((scroll > 0) && ($('.dropdown').hasClass('open'))) { $('.dropdown').removeClass('open'); $('.button--dropdown').attr("aria-expanded","false");
Space between the comma and "false"
portal/templates/portal/base.html, line 365 at r1 (raw file): Previously, faucomte97 (Florian Aucomte) wrote…
There is actually no space there x) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @mariaFernando)
portal/templates/portal/base.html, line 365 at r1 (raw file):
Previously, mariaFernando (Maria Mafalda Fernando) wrote…
There is actually no space there x)
I know, I'm asking you to put one in xD
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @mariaFernando)
portal/templates/portal/base.html, line 365 at r1 (raw file): Previously, faucomte97 (Florian Aucomte) wrote…
ohhOOOHHH |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3.
Reviewable status:complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status:
complete! all files reviewed, all discussions resolved
portal/templates/portal/base.html, line 365 at r1 (raw file):
Previously, mariaFernando (Maria Mafalda Fernando) wrote…
ohhOOOHHH
Done.
Changed z-indexes so that the elements are properly placed and the dropdown menu gets closed when the user scrolls so it doesn't become unreachable on Rapid Router's page.
This change is![Reviewable](https://camo.githubusercontent.com/23b05f5fb48215c989e92cc44cf6512512d083132bd3daf689867c8d9d386888/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)