Added support for Django 1.11 #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pwilczynskiclearcode
force-pushed
the
master
branch
2 times, most recently
from
73a0867
to
111d14f
Compare
| from django.contrib.messages import constants | ||
| from django.core.urlresolvers import resolve, reverse, NoReverseMatch, Resolver404 | ||
| from django.template.loader import get_template | ||
| from django.template.base import token_kwargs, FilterExpression | ||
| from django.template.loader_tags import do_extends, ExtendsNode | ||
| from django.template.defaultfilters import slugify | ||
| from django.utils.html import format_html | ||
| from ast import literal_eval |
There was a problem hiding this comment.
literal_eval isn't used anywhere
| context_dict = context.flatten() | ||
| return form_template.render(context_dict, context_dict.get('request')) | ||
| else: | ||
| return form_template.render(context) |
There was a problem hiding this comment.
mikebryant
requested changes
Feb 23, 2018
.travis.yml
Outdated
| @@ -28,5 +29,5 @@ deploy: | |||
| distributions: "bdist_wheel sdist" | |||
| on: | |||
| all_branches: true | |||
| condition: $DJANGO_VERSION = ">=1.10, < 1.11" | |||
| condition: $DJANGO_VERSION = ">=1.10, < 2.0" | |||
There was a problem hiding this comment.
This is wrong - it needs to match one of the above entries.
e.g. here it should be condition: $DJANGO_VERSION = ">=1.11, < 2.0"
pwilczynskiclearcode
force-pushed
the
master
branch
from
111d14f
to
e1b619c
Compare
mikebryant
approved these changes
Feb 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.