Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature(label): Add outline class #491

Merged
merged 2 commits into from
Jul 11, 2018
Merged

feature(label): Add outline class #491

merged 2 commits into from
Jul 11, 2018

Conversation

charlieTheBotDev
Copy link
Contributor

Description

  • Added hx-label-outline
  • Added transparent border to regular labels to prevent visual difference between outline vs non-outline labels
  • Documented changes

Motivation and Context

Resolves #247

How Has This Been Tested?

Visual testing

Screenshots (if appropriate):

Screenshot

Checklist:

  • I have added a tag to this pull request that indicates the impact of the change (patch, minor or major)
  • My code follows the code style of this project.
  • I have updated the documentation accordingly. (This includes updating the changelog).
  • I have read the CONTRIBUTING document.
  • All my changes are covered by tests.
  • This request is ready to review and merge

@jmsmyth jmsmyth changed the title feature(label): Add outline classe feature(label): Add outline class Jul 10, 2018
@charlieTheBotDev charlieTheBotDev merged commit f27be74 into 1-17-0 Jul 11, 2018
@charlieTheBotDev charlieTheBotDev deleted the 247_label-outline branch July 11, 2018 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmsmyth jmsmyth jmsmyth approved these changes

Assignees
No one assigned
Labels
Minor Release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@charlieTheBotDev @jmsmyth