Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: improve test speed by making the preferences tests use fake timers #539

Merged
merged 2 commits into from
Aug 7, 2019
Merged

tests: improve test speed by making the preferences tests use fake timers #539

merged 2 commits into from
Aug 7, 2019

Conversation

charlieTheBotDev
Copy link
Contributor

Description

Use fake timers in preferences tests.

Motivation and Context

Speeds up tests, stops modal flashing on screen during tests.

Checklist:

  • I have added a tag to this pull request that indicates the impact of the change (patch, minor or major)
  • My code follows the code style of this project.
  • I have updated the documentation accordingly. (This includes updating the changelog).
  • I have read the CONTRIBUTING document. (Last updated 18th May 2019)
  • All my changes are covered by tests.
  • This request is ready to review and merge

@charlieTheBotDev
tests: use fake timers in the preferences tests to speed them up
298cf41 
Also resolves issues where the notifications don't disappear when the
next test suite calls `installFakeTimers` and removes the existing
timeouts on the notifications.
@charlieTheBotDev
chore(security): update package-lock to patch security issues
7c95591
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 68.036% when pulling 7c95591 on NO-ISSUE_preferences into bc7e232 on master.

@charlieTheBotDev charlieTheBotDev merged commit b5cd611 into master Aug 7, 2019
@charlieTheBotDev charlieTheBotDev deleted the NO-ISSUE_preferences branch April 3, 2020 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Patch Release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@charlieTheBotDev @coveralls